Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Add lower and upper support for string #635

Closed
Xuanwo opened this issue Nov 26, 2021 · 2 comments · Fixed by #664
Closed

Add lower and upper support for string #635

Xuanwo opened this issue Nov 26, 2021 · 2 comments · Fixed by #664
Labels
feature A new feature

Comments

@Xuanwo
Copy link
Contributor

Xuanwo commented Nov 26, 2021

Hello, do you have a plan to support compute::lower::lower and compute::upper::upper?

If it's OK, I will start a PR to implement those two functions.

They are required by databendlabs/databend#3013 and databendlabs/databend#3010
@Xuanwo Xuanwo moved this to In Design in Xuanwo's Work Nov 26, 2021
@jorgecarleitao jorgecarleitao added the feature A new feature label Nov 26, 2021
@jorgecarleitao
Copy link
Owner

Yeap, in scope indeed. 👍

Hint: there is a cool optimization on them

@Xuanwo
Copy link
Contributor Author

Xuanwo commented Nov 27, 2021

Hint: there is a cool optimization on them

Wow, sounds interesting. How about giving me some more detailed tips?

@Xuanwo Xuanwo mentioned this issue Nov 27, 2021
Merged
@Xuanwo Xuanwo moved this from In Design to In Progress in Xuanwo's Work Nov 27, 2021
@Xuanwo Xuanwo mentioned this issue Nov 27, 2021
Closed
@Xuanwo Xuanwo changed the title Question: Is it OK to add lower and upper support for string? Add lower and upper support for string Nov 27, 2021
@Xuanwo Xuanwo mentioned this issue Dec 7, 2021
Merged
@Xuanwo Xuanwo moved this from 🔨 In Progress to 📦 Done in Xuanwo's Work Dec 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature A new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added upper Xuanwo/arrow2
2 participants
@jorgecarleitao @Xuanwo