-
Notifications
You must be signed in to change notification settings - Fork 224
Conversation
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Codecov Report
@@ Coverage Diff @@
## main #641 +/- ##
==========================================
+ Coverage 69.91% 69.94% +0.02%
==========================================
Files 299 300 +1
Lines 16628 16644 +16
==========================================
+ Hits 11625 11641 +16
Misses 5003 5003
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! Left some comments
Co-authored-by: Jorge Leitao <jorgecarleitao@gmail.com>
Shouldn't the test include some real UTF8 characters instead of only the ASCII subset? |
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Addressed, thanks for advice. |
Signed-off-by: Xuanwo <github@xuanwo.io>
Thanks a lot, really well tested! 💯 |
Signed-off-by: Xuanwo github@xuanwo.io
Part of #635