Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Support Decimal in build_compare() #997

Closed
GPSnoopy opened this issue May 20, 2022 · 1 comment
Closed

Support Decimal in build_compare() #997

GPSnoopy opened this issue May 20, 2022 · 1 comment
Labels
enhancement An improvement to an existing feature no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog

Comments

@GPSnoopy
Copy link
Contributor

This is similar to arrow-rs PR apache/arrow-rs#1487.

I suspect adding a single-line match like (Decimal(_,_), Decimal(_,_) => compare_primitives::<i128>(left, right), ought to be enough.

I will give a PR a go.
@GPSnoopy GPSnoopy mentioned this issue May 20, 2022
Merged
@GPSnoopy
Copy link
Contributor Author

Closing issue, related PR has been merged.

@jorgecarleitao jorgecarleitao added enhancement An improvement to an existing feature no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog labels May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement An improvement to an existing feature no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jorgecarleitao @GPSnoopy