Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added support for Decimal in build_compare #998

Merged
merged 4 commits into from
May 21, 2022
Merged

Added support for Decimal in build_compare #998

merged 4 commits into from
May 21, 2022

Conversation

GPSnoopy
Copy link
Contributor

Fixes Issue #997.

@jorgecarleitao jorgecarleitao changed the title Add support for Decimal in build_compare(). Added support for Decimal in build_compare May 21, 2022
@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label May 21, 2022
@codecov
Copy link

codecov bot commented May 21, 2022

Codecov Report

Merging #998 (e6307b5) into main (267cac0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #998   +/-   ##
=======================================
  Coverage   71.41%   71.42%           
=======================================
  Files         357      356    -1     
  Lines       19799    19784   -15     
=======================================
- Hits        14139    14130    -9     
+ Misses       5660     5654    -6     
Impacted Files Coverage Δ
src/array/ord.rs 71.60% <100.00%> (+0.35%) ⬆️
src/ffi/schema.rs 67.53% <0.00%> (-0.63%) ⬇️
src/ffi/array.rs 82.50% <0.00%> (-0.43%) ⬇️
src/types/bit_chunk.rs 100.00% <0.00%> (ø)
src/types/offset.rs
src/ffi/stream.rs 63.21% <0.00%> (+0.29%) ⬆️
src/io/avro/read/deserialize.rs 72.45% <0.00%> (+0.42%) ⬆️
src/bitmap/utils/slice_iterator.rs 87.93% <0.00%> (+1.72%) ⬆️
...c/io/parquet/read/deserialize/binary/dictionary.rs 90.90% <0.00%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 267cac0...e6307b5. Read the comment docs.

Copy link
Owner

@jorgecarleitao jorgecarleitao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for it!

@jorgecarleitao jorgecarleitao merged commit a10db3a into jorgecarleitao:main May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants