Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Made parquet_to_arrow_schema public #1006

Merged
merged 3 commits into from
May 24, 2022

Conversation

martingallagher
Copy link
Contributor

Exposes the utility function to go from parquet2's SchemaDescriptor to arrow2 Schema

Maybe a arrow2::schema::Schema::try_from_message is more desirable?

@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #1006 (8b127ce) into main (a810b03) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1006   +/-   ##
=======================================
  Coverage   71.44%   71.45%           
=======================================
  Files         356      356           
  Lines       19752    19758    +6     
=======================================
+ Hits        14112    14118    +6     
  Misses       5640     5640           
Impacted Files Coverage Δ
src/io/parquet/read/schema/mod.rs 100.00% <ø> (ø)
src/compute/arithmetics/time.rs 25.68% <0.00%> (-0.92%) ⬇️
src/compute/aggregate/min_max.rs 75.36% <0.00%> (+1.11%) ⬆️
src/bitmap/utils/slice_iterator.rs 87.93% <0.00%> (+1.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a810b03...8b127ce. Read the comment docs.

@jorgecarleitao
Copy link
Owner

Hey, thanks a lot for this!

Would it be possible to use pub use convert::parquet_to_arrow_schema instead? It makes it a bit easier to follow what is being exported exactly when reading the code.

@jorgecarleitao jorgecarleitao merged commit 5725fa3 into jorgecarleitao:main May 24, 2022
@jorgecarleitao jorgecarleitao changed the title Make convert mod public to expose parquet_to_arrow_schema utility function Made parquet_to_arrow_schema public May 24, 2022
@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label May 24, 2022
@martingallagher martingallagher deleted the pub-convert branch May 24, 2022 08:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants