Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Treat empty timezone string as no-timezone #1009

Merged
merged 6 commits into from
May 26, 2022
Merged

Treat empty timezone string as no-timezone #1009

merged 6 commits into from
May 26, 2022

Conversation

dbr
Copy link
Contributor

@dbr dbr commented May 26, 2022

@jorgecarleitao jorgecarleitao added the bug Something isn't working label May 26, 2022
@jorgecarleitao
Copy link
Owner

Thank you! The code is much cleaner, also!

@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #1009 (9ec6dbb) into main (5725fa3) will increase coverage by 0.00%.
The diff coverage is 27.45%.

@@           Coverage Diff           @@
##             main    #1009   +/-   ##
=======================================
  Coverage   71.45%   71.45%           
=======================================
  Files         356      356           
  Lines       19758    19762    +4     
=======================================
+ Hits        14118    14121    +3     
- Misses       5640     5641    +1     
Impacted Files Coverage Δ
src/array/primitive/fmt.rs 68.65% <ø> (ø)
src/ffi/schema.rs 67.62% <27.45%> (+0.09%) ⬆️
src/bitmap/utils/slice_iterator.rs 86.20% <0.00%> (-1.73%) ⬇️
src/compute/arithmetics/time.rs 26.60% <0.00%> (+0.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5725fa3...9ec6dbb. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit ed4734f into jorgecarleitao:main May 26, 2022
@dbr dbr deleted the ffitimezone branch May 27, 2022 08:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants