Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fixed panic on debug print of invalid timezones #1013

Merged
merged 1 commit into from
May 27, 2022
Merged

Conversation

jorgecarleitao
Copy link
Owner

Closes #903

@jorgecarleitao jorgecarleitao added the bug Something isn't working label May 26, 2022
@jorgecarleitao jorgecarleitao marked this pull request as ready for review May 26, 2022 20:10
@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #1013 (127776e) into main (ed4734f) will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main    #1013   +/-   ##
=======================================
  Coverage   71.46%   71.46%           
=======================================
  Files         356      356           
  Lines       19762    19770    +8     
=======================================
+ Hits        14122    14128    +6     
- Misses       5640     5642    +2     
Impacted Files Coverage Δ
src/array/primitive/fmt.rs 68.00% <66.66%> (-0.66%) ⬇️
src/temporal_conversions.rs 76.87% <0.00%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed4734f...127776e. Read the comment docs.

@jorgecarleitao jorgecarleitao changed the title Fixed panic on debug print of invalid tz Fixed panic on debug print of invalid timezones May 26, 2022
@dbr
Copy link
Contributor

dbr commented May 27, 2022

Tested, and change looks good to me 🥳

It's a bit of a shame to lose the "Invalid Offset format (must be [-]00:00) or chrono-tz feature not active" message, but not panicing is a huge improvement, and keeping this message doesn't seem worth the significant change required I think!

@jorgecarleitao jorgecarleitao merged commit b5bbe9f into main May 27, 2022
@jorgecarleitao jorgecarleitao deleted the fix_debug_tz branch May 27, 2022 03:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic when printing debug arrays with invalid timezones
2 participants