Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fixed error in consuming sliced FixedSizedBinary from c data interface (FFI) #1026

Merged
merged 1 commit into from
May 31, 2022

Conversation

jorgecarleitao
Copy link
Owner

@jorgecarleitao jorgecarleitao commented May 30, 2022

The (fixed) size of the array must be taken into account when offsetting the values buffer.

This resulted in reading less elements than required (i.e. it would never cause a read out of bounds).

@jorgecarleitao jorgecarleitao added the bug Something isn't working label May 30, 2022
@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #1026 (f350daf) into main (c013e49) will increase coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1026      +/-   ##
==========================================
+ Coverage   71.62%   71.86%   +0.24%     
==========================================
  Files         359      359              
  Lines       19916    19916              
==========================================
+ Hits        14264    14313      +49     
+ Misses       5652     5603      -49     
Impacted Files Coverage Δ
src/ffi/array.rs 86.62% <ø> (+2.54%) ⬆️
src/array/list/mod.rs 70.79% <0.00%> (+0.88%) ⬆️
src/compute/arithmetics/time.rs 26.60% <0.00%> (+0.91%) ⬆️
src/array/mod.rs 68.08% <0.00%> (+1.06%) ⬆️
src/array/fixed_size_binary/mod.rs 90.29% <0.00%> (+1.94%) ⬆️
src/ffi/schema.rs 75.08% <0.00%> (+6.79%) ⬆️
src/array/ffi.rs 85.00% <0.00%> (+10.00%) ⬆️
src/ffi/bridge.rs 83.33% <0.00%> (+11.11%) ⬆️
src/array/fixed_size_binary/ffi.rs 60.00% <0.00%> (+60.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c013e49...f350daf. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant