Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fixed missing validation of number of encodings passed when writing to parquet #1057

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

jorgecarleitao
Copy link
Owner

Not doing so resulted in an incorrectly written parquet file :/

@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #1057 (69be888) into main (6608071) will decrease coverage by 0.07%.
The diff coverage is 48.14%.

@@            Coverage Diff             @@
##             main    #1057      +/-   ##
==========================================
- Coverage   81.32%   81.25%   -0.08%     
==========================================
  Files         363      363              
  Lines       34649    34673      +24     
==========================================
- Hits        28179    28173       -6     
- Misses       6470     6500      +30     
Impacted Files Coverage Δ
src/io/parquet/write/row_group.rs 87.01% <46.15%> (-8.30%) ⬇️
src/io/parquet/write/sink.rs 72.17% <50.00%> (-3.79%) ⬇️
src/chunk.rs 83.33% <0.00%> (-2.39%) ⬇️
src/io/parquet/read/indexes/primitive.rs 34.70% <0.00%> (-2.36%) ⬇️
src/io/json/read/deserialize.rs 72.62% <0.00%> (-2.29%) ⬇️
src/compute/aggregate/memory.rs 35.71% <0.00%> (-1.79%) ⬇️
src/io/parquet/read/file.rs 84.27% <0.00%> (-1.26%) ⬇️
src/io/ipc/write/schema.rs 98.00% <0.00%> (-0.41%) ⬇️
src/ffi/array.rs 89.24% <0.00%> (-0.36%) ⬇️
src/io/parquet/read/deserialize/nested_utils.rs 83.84% <0.00%> (-0.31%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6608071...69be888. Read the comment docs.

@jorgecarleitao jorgecarleitao changed the title Added validation of number of encodings passed to parquet writing Fixed missing validation of number of encodings passed when writing to parquet Jun 7, 2022
@jorgecarleitao jorgecarleitao merged commit 86e533f into main Jun 7, 2022
@jorgecarleitao jorgecarleitao deleted the fix_error branch June 7, 2022 22:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant