This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the culmination of a number of great ideas from @ritchie46, @sundy-li, @houqp, and myself over the last 8 months or so. Thanks a lot everyone for all the fun and learnings so far :)
It contains a set of APIs over
Buffer
,Bitmap
,MutableBitmap
,PrimitiveArray
andBooleanArray
that enable operations in-place (i.e. without allocations).In summary, this PR adds support for clone-on-write over
BooleanArray
andPrimitiveArray
, both on values and validity, allowing composite expressions evaluation to take at most 1 allocation while preserving their SIMD nature.Benches
Apply a transformation to the values of a f32 array vs returning a new array:
Apply a transformation to the values of a boolean array vs creating a new array:
#1042 will make this easier to use when the trait object
Array
is used. This PR motivates that change.