Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added cast to/from Null from/to every type #1066

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Added cast to/from Null from/to every type #1066

merged 1 commit into from
Jun 10, 2022

Conversation

jorgecarleitao
Copy link
Owner

We limited what types we accepted on the cast, but do support any type :)

@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Jun 10, 2022
@jorgecarleitao jorgecarleitao changed the title Improved cast to/from Null Added cast to/from Null from/to every type Jun 10, 2022
@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #1066 (f47916b) into main (b0c601e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1066      +/-   ##
==========================================
+ Coverage   81.32%   81.33%   +0.01%     
==========================================
  Files         363      363              
  Lines       34685    34689       +4     
==========================================
+ Hits        28206    28214       +8     
+ Misses       6479     6475       -4     
Impacted Files Coverage Δ
src/compute/cast/mod.rs 94.65% <100.00%> (ø)
src/io/parquet/read/deserialize/null.rs 0.00% <0.00%> (ø)
src/io/parquet/write/schema.rs 69.09% <0.00%> (+2.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0c601e...f47916b. Read the comment docs.

@ritchie46
Copy link
Collaborator

That's useful!

@jorgecarleitao jorgecarleitao merged commit a3f050a into main Jun 10, 2022
@jorgecarleitao jorgecarleitao deleted the null_cast branch June 10, 2022 15:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants