Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added compute::arity_assign #1070

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Added compute::arity_assign #1070

merged 1 commit into from
Jun 14, 2022

Conversation

jorgecarleitao
Copy link
Owner

The clone-on-write counterpart of compute::arity - it avoids memcopies when the lhs can be mutated in place. It offers a 2.2x improvement when both arrays have values and validity vs compute::arity:

apply_mul null 2^20     time:   [142.24 us 142.85 us 143.47 us]
mul null 2^20           time:   [318.90 us 319.91 us 320.93 us]

@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Jun 13, 2022
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #1070 (aa4eafa) into main (76d2a39) will increase coverage by 0.01%.
The diff coverage is 92.59%.

@@            Coverage Diff             @@
##             main    #1070      +/-   ##
==========================================
+ Coverage   81.00%   81.02%   +0.01%     
==========================================
  Files         365      366       +1     
  Lines       35023    35050      +27     
==========================================
+ Hits        28372    28400      +28     
+ Misses       6651     6650       -1     
Impacted Files Coverage Δ
src/compute/arity_assign.rs 92.59% <92.59%> (ø)
src/io/ipc/write/serialize.rs 96.15% <0.00%> (-0.15%) ⬇️
src/io/ipc/read/stream_async.rs 74.38% <0.00%> (+0.82%) ⬆️
src/bitmap/assign_ops.rs 83.87% <0.00%> (+2.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76d2a39...aa4eafa. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 83082fa into main Jun 14, 2022
@jorgecarleitao jorgecarleitao deleted the arity_assign branch June 14, 2022 04:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant