Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Renamed Bitmap::null_count to Bitmap::unset_bits #1087

Merged
merged 1 commit into from
Jun 20, 2022
Merged

Conversation

jorgecarleitao
Copy link
Owner

null_count is not a very relatable name to a "bitmap", since the association null <> unset_bit only emerges in arrays - this PR renames the function (and marks the old as deprecated).

@codecov
Copy link

codecov bot commented Jun 19, 2022

Codecov Report

Merging #1087 (f1a0bcc) into main (d1ab4ef) will increase coverage by 0.02%.
The diff coverage is 91.22%.

@@            Coverage Diff             @@
##             main    #1087      +/-   ##
==========================================
+ Coverage   81.07%   81.10%   +0.02%     
==========================================
  Files         367      367              
  Lines       35309    35315       +6     
==========================================
+ Hits        28628    28641      +13     
+ Misses       6681     6674       -7     
Impacted Files Coverage Δ
src/io/parquet/write/binary/basic.rs 68.14% <0.00%> (ø)
src/bitmap/mutable.rs 96.86% <40.00%> (-0.66%) ⬇️
src/bitmap/immutable.rs 81.48% <90.00%> (-1.54%) ⬇️
src/array/binary/mutable.rs 87.97% <100.00%> (ø)
src/array/boolean/mutable.rs 89.32% <100.00%> (ø)
src/array/mod.rs 68.54% <100.00%> (ø)
src/array/physical_binary.rs 97.67% <100.00%> (ø)
src/array/primitive/mutable.rs 95.57% <100.00%> (ø)
src/array/utf8/mutable.rs 84.00% <100.00%> (ø)
src/bitmap/assign_ops.rs 83.06% <100.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1ab4ef...f1a0bcc. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit e3a005d into main Jun 20, 2022
@jorgecarleitao jorgecarleitao deleted the rename_null branch June 20, 2022 21:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant