-
Notifications
You must be signed in to change notification settings - Fork 221
Added support for projections in reading IPC streams #1097
Added support for projections in reading IPC streams #1097
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1097 +/- ##
==========================================
+ Coverage 81.19% 81.22% +0.02%
==========================================
Files 367 367
Lines 35340 35369 +29
==========================================
+ Hits 28695 28727 +32
+ Misses 6645 6642 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flawless. This is ready to merge from the src
and tests
. Amazing work, @joshuataylor !
There is a small fix we need to apply - in integration-testing/src/bin/arrow-stream-to-file.rs:27:35
we need to add None
to the call, since the API changed.
Ah, missed those, added it. Will remember to keep an eye on CI. |
Thanks! The CI for integration has been failing lately between C# and X. We use the same steps as apache/arrow and that is an issue from there. So, as long as there is not there all is good (I do not expect any impact - if it compiles we are good). |
Adds projections to IPC Streams, which is required for pola-rs/polars#3778 which in turn is required for elixir-explorer/explorer#265 🚀
As this is my first PR, and I'm new to Rust, please give any feedback you find helpful 🙌
Closes #1095
Backward incompatible changes
StreamReader::new
has a new argument,projection
. AddNone
to it to retain the original behavior.