Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Removed unused NativeType::to_ne_bytes #1112

Merged
merged 2 commits into from
Jun 28, 2022
Merged

Removed unused NativeType::to_ne_bytes #1112

merged 2 commits into from
Jun 28, 2022

Conversation

jorgecarleitao
Copy link
Owner

This is an old function that is not really used nor needed (since ne does not take endianess into account).

Also added a bunch of tests covering from and to bytes of custom types.

@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #1112 (c2d01f5) into main (b942a84) will increase coverage by 0.54%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main    #1112      +/-   ##
==========================================
+ Coverage   81.33%   81.88%   +0.54%     
==========================================
  Files         367      367              
  Lines       35458    35769     +311     
==========================================
+ Hits        28840    29289     +449     
+ Misses       6618     6480     -138     
Impacted Files Coverage Δ
src/types/native.rs 67.92% <80.00%> (+44.32%) ⬆️
src/array/utf8/mod.rs 85.62% <100.00%> (-5.18%) ⬇️
src/io/parquet/read/deserialize/boolean/basic.rs 93.41% <0.00%> (-1.08%) ⬇️
...rc/io/parquet/read/deserialize/primitive/nested.rs 87.96% <0.00%> (-0.27%) ⬇️
src/io/parquet/read/deserialize/nested_utils.rs 83.71% <0.00%> (-0.23%) ⬇️
src/io/ipc/read/reader.rs 96.38% <0.00%> (+0.36%) ⬆️
src/io/parquet/read/deserialize/boolean/nested.rs 68.10% <0.00%> (+1.04%) ⬆️
src/io/parquet/read/deserialize/binary/basic.rs 76.47% <0.00%> (+1.27%) ⬆️
...arquet/read/deserialize/fixed_size_binary/basic.rs 97.20% <0.00%> (+1.37%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b942a84...c2d01f5. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant