Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Removed need to pass encodings by value #1123

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

ritchie46
Copy link
Collaborator

array_to_columns could do with a slice as Encoding
is Copy

array_to_columns could do with a slice as `Encoding`
is `Copy`
@ritchie46 ritchie46 changed the title parquet: Don't take ownership of Vec<Eccoding> parquet: Don't take ownership of Vec<Encoding> Jun 29, 2022
@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #1123 (f383506) into main (f57dbd5) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1123   +/-   ##
=======================================
  Coverage   83.38%   83.38%           
=======================================
  Files         367      367           
  Lines       35566    35566           
=======================================
  Hits        29658    29658           
  Misses       5908     5908           
Impacted Files Coverage Δ
src/io/parquet/write/pages.rs 95.85% <100.00%> (ø)
src/io/parquet/write/row_group.rs 87.01% <100.00%> (ø)
src/array/binary/mod.rs 88.88% <0.00%> (-1.24%) ⬇️
src/io/ipc/read/stream_async.rs 76.69% <0.00%> (-0.76%) ⬇️
src/io/ipc/read/reader.rs 96.38% <0.00%> (ø)
src/array/utf8/mod.rs 86.58% <0.00%> (+0.95%) ⬆️
src/bitmap/utils/slice_iterator.rs 98.78% <0.00%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f57dbd5...f383506. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 3c49124 into jorgecarleitao:main Jun 29, 2022
@jorgecarleitao jorgecarleitao changed the title parquet: Don't take ownership of Vec<Encoding> Removed need to pass encoding by value Jun 29, 2022
@jorgecarleitao jorgecarleitao changed the title Removed need to pass encoding by value Removed need to pass encodings by value Jun 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants