Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Reduced allocations of reading bitmaps from IPC #1126

Merged
merged 3 commits into from
Jul 1, 2022
Merged

Conversation

jorgecarleitao
Copy link
Owner

(Built on top of #1125), this uses the same ideas by @ritchie46 on #1105 for bitmaps.

@jorgecarleitao jorgecarleitao requested a review from ritchie46 June 29, 2022 14:27
@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Jun 29, 2022
@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #1126 (5b3e897) into main (f57dbd5) will increase coverage by 0.02%.
The diff coverage is 86.77%.

@@            Coverage Diff             @@
##             main    #1126      +/-   ##
==========================================
+ Coverage   83.38%   83.41%   +0.02%     
==========================================
  Files         367      366       -1     
  Lines       35566    35632      +66     
==========================================
+ Hits        29658    29722      +64     
- Misses       5908     5910       +2     
Impacted Files Coverage Δ
src/error.rs 42.50% <0.00%> (-3.45%) ⬇️
src/io/ipc/read/file_async.rs 60.70% <65.00%> (-0.06%) ⬇️
src/io/ipc/read/stream_async.rs 76.55% <69.23%> (-0.90%) ⬇️
src/io/ipc/read/array/binary.rs 92.42% <100.00%> (+0.11%) ⬆️
src/io/ipc/read/array/boolean.rs 90.19% <100.00%> (+0.61%) ⬆️
src/io/ipc/read/array/dictionary.rs 86.66% <100.00%> (ø)
src/io/ipc/read/array/fixed_size_binary.rs 87.03% <100.00%> (+0.24%) ⬆️
src/io/ipc/read/array/fixed_size_list.rs 87.50% <100.00%> (+0.22%) ⬆️
src/io/ipc/read/array/list.rs 77.33% <100.00%> (+0.30%) ⬆️
src/io/ipc/read/array/map.rs 76.38% <100.00%> (+0.33%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f57dbd5...5b3e897. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit b3583b6 into main Jul 1, 2022
@jorgecarleitao jorgecarleitao deleted the bitmap_reuse branch July 1, 2022 13:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant