Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Simplified code in flight integration tests #1136

Merged
merged 4 commits into from
Jul 3, 2022
Merged

Conversation

jorgecarleitao
Copy link
Owner

@jorgecarleitao jorgecarleitao commented Jul 2, 2022

This PR cleans up the code used to run Flight integration tests.

Main changes are:

  • replaced usage of bounded channels by try_stream (server and client)
  • simplified the creation of the stream of FlightData (client)
  • added instructions on how to run the tests
  • simplified naming

@jorgecarleitao jorgecarleitao added the testing PRs that only increase coverage label Jul 2, 2022
@codecov
Copy link

codecov bot commented Jul 2, 2022

Codecov Report

Merging #1136 (c6f5371) into main (b3583b6) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1136      +/-   ##
==========================================
- Coverage   83.49%   83.48%   -0.01%     
==========================================
  Files         366      366              
  Lines       35635    35635              
==========================================
- Hits        29752    29751       -1     
- Misses       5883     5884       +1     
Impacted Files Coverage Δ
src/array/utf8/mod.rs 85.62% <0.00%> (-0.96%) ⬇️
src/io/ipc/read/reader.rs 96.53% <0.00%> (ø)
src/bitmap/immutable.rs 84.56% <0.00%> (+0.61%) ⬆️
src/bitmap/utils/slice_iterator.rs 98.78% <0.00%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3583b6...c6f5371. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit f5f6b7e into main Jul 3, 2022
@jorgecarleitao jorgecarleitao deleted the clean_flight branch July 3, 2022 02:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
testing PRs that only increase coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant