This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Fixed panic in deserializing nested statistics #1139
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deserializing nested statistics from parquet, we need to take into account that the null count of a
List[Struct]
can't beUInt64
and should instead be something likeList[{"a": null_a, "b": null_b}]
. This PR fixes this.I think we can still improve this a bit (e.g. why not
{"a": null_a, "b": null_b}
instead?) so that users can use nested statistics to create predicates for filter pushdown of nested types, but at least this no longer panics.