Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fixed error in reading Struct<List<...>> from parquet #1150

Merged
merged 1 commit into from
Jul 9, 2022

Conversation

jorgecarleitao
Copy link
Owner

Thanks to @andrei-ionescu for reporting this at pola-rs/polars#3942 and providing an example file where this would happen.

@jorgecarleitao jorgecarleitao added the bug Something isn't working label Jul 9, 2022
@codecov
Copy link

codecov bot commented Jul 9, 2022

Codecov Report

Merging #1150 (1e198e9) into main (ba45d55) will increase coverage by 0.05%.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##             main    #1150      +/-   ##
==========================================
+ Coverage   83.66%   83.71%   +0.05%     
==========================================
  Files         366      366              
  Lines       35912    35919       +7     
==========================================
+ Hits        30044    30069      +25     
+ Misses       5868     5850      -18     
Impacted Files Coverage Δ
src/array/struct_/mod.rs 61.45% <0.00%> (ø)
src/io/parquet/read/deserialize/nested_utils.rs 84.24% <100.00%> (+1.34%) ⬆️
src/io/ipc/read/reader.rs 96.65% <0.00%> (+0.66%) ⬆️
src/io/parquet/read/deserialize/mod.rs 85.91% <0.00%> (+1.03%) ⬆️
src/array/equal/struct_.rs 70.73% <0.00%> (+24.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba45d55...1e198e9. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 890853c into main Jul 9, 2022
@jorgecarleitao jorgecarleitao deleted the fix_parquet branch July 9, 2022 17:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant