This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Improved checks to safety invariants in FFI #1154
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
assert
s by errors on reading fromFFI
, and makes the docs of internal functions more explicit about what is the invariant being up-held. It does not cover every invariant that the "C data interface" requires, but it bring us closer to it.Note that this does not change anything about the
unsafe
of the FFI - the main change is that we no longer panic if the passed data is incorrect, we just error. We further error if pointers are not properly aligned (which are part of the C data interface invariant but we can check them atO(1)
and provide a good error message).