Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Removed unneeded Default constraint #1157

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Removed unneeded Default constraint #1157

merged 1 commit into from
Jul 12, 2022

Conversation

hohav
Copy link
Contributor

@hohav hohav commented Jul 12, 2022

I was trying to use MutableListArray with a type that doesn't implement Default, and ran into an error caused by this constraint. It looks unnecessary, and removing it doesn't seem to break anything.

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #1157 (47132b3) into main (1d52cbf) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1157      +/-   ##
==========================================
+ Coverage   83.66%   83.68%   +0.01%     
==========================================
  Files         365      365              
  Lines       35865    35865              
==========================================
+ Hits        30006    30013       +7     
+ Misses       5859     5852       -7     
Impacted Files Coverage Δ
src/array/list/mutable.rs 76.04% <ø> (ø)
src/chunk.rs 83.33% <0.00%> (-7.15%) ⬇️
src/io/ipc/read/file_async.rs 60.44% <0.00%> (-0.38%) ⬇️
src/buffer/immutable.rs 89.33% <0.00%> (ø)
src/io/ipc/read/reader.rs 96.32% <0.00%> (ø)
src/io/ipc/read/stream_async.rs 76.02% <0.00%> (ø)
src/array/utf8/mod.rs 86.58% <0.00%> (+0.95%) ⬆️
src/io/ipc/read/array/fixed_size_binary.rs 94.73% <0.00%> (+7.01%) ⬆️
src/io/ipc/read/array/boolean.rs 98.14% <0.00%> (+7.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d52cbf...47132b3. Read the comment docs.

@jorgecarleitao
Copy link
Owner

Thanks a lot, @hohav !

@jorgecarleitao jorgecarleitao merged commit 4866302 into jorgecarleitao:main Jul 12, 2022
@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Jul 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants