Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added constructor MutableFixedSizeListArray::new_from #1161

Merged
merged 3 commits into from
Jul 17, 2022
Merged

Added constructor MutableFixedSizeListArray::new_from #1161

merged 3 commits into from
Jul 17, 2022

Conversation

hohav
Copy link
Contributor

@hohav hohav commented Jul 13, 2022

Implements a more general MutableFixedSizeListArray constructor, new_from, to allow creating one with a non-nullable datatype (since default_datatype creates one that's nullable).

@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #1161 (20f20f9) into main (91e1ef7) will decrease coverage by 0.01%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main    #1161      +/-   ##
==========================================
- Coverage   83.61%   83.59%   -0.02%     
==========================================
  Files         365      365              
  Lines       35914    35908       -6     
==========================================
- Hits        30029    30018      -11     
- Misses       5885     5890       +5     
Impacted Files Coverage Δ
src/array/fixed_size_list/mutable.rs 52.94% <85.71%> (-0.85%) ⬇️
src/compute/boolean_kleene.rs 68.35% <0.00%> (-6.01%) ⬇️
src/compute/comparison/mod.rs 54.07% <0.00%> (-0.68%) ⬇️
src/io/flight/mod.rs 67.00% <0.00%> (-0.33%) ⬇️
src/io/ipc/read/common.rs 94.90% <0.00%> (-0.02%) ⬇️
src/buffer/immutable.rs 89.33% <0.00%> (ø)
src/bitmap/immutable.rs 84.56% <0.00%> (+0.61%) ⬆️
src/io/ipc/read/schema.rs 95.49% <0.00%> (+0.92%) ⬆️
src/compute/boolean.rs 97.22% <0.00%> (+2.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91e1ef7...20f20f9. Read the comment docs.

Copy link
Owner

@jorgecarleitao jorgecarleitao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

I left a small comment.

src/array/fixed_size_list/mutable.rs Show resolved Hide resolved
@jorgecarleitao jorgecarleitao merged commit 3fdb33f into jorgecarleitao:main Jul 17, 2022
@jorgecarleitao jorgecarleitao changed the title Added constructor new_from Added constructor MutableFixedSizeListArray::new_from Jul 17, 2022
@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Jul 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants