Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Dict parquet nested update #1172

Closed

Conversation

ritchie46
Copy link
Collaborator

Continued from dict_parquet_nested. I thought I open a draft PR so we can make PR's on this branch more easily.

This fixed a few compilation problems and did a rebase on main. Remaining errors needs two missing function implemenations and a few other things where I don't really know what it should be:

error[E0425]: cannot find function `read_optional_values` in this scope
   --> src/io/parquet/read/deserialize/dictionary/nested.rs:121:17
    |
121 |                 read_optional_values(items, values, validity)
    |                 ^^^^^^^^^^^^^^^^^^^^ not found in this scope

error[E0425]: cannot find function `extend_offsets1` in this scope
   --> src/io/parquet/read/deserialize/dictionary/nested.rs:189:13
    |
189 |             extend_offsets1(&mut nested_page, init, nested_items, chunk_size);
    |             ^^^^^^^^^^^^^^^ not found in this scope

error[E0599]: the method `by_ref` exists for mutable reference `&mut parquet::read::deserialize::dictionary::Optional<'_>`, but its trait bounds were not satisfied
   --> src/io/parquet/read/deserialize/dictionary/nested.rs:118:43
    |
118 |                 let items = page_validity.by_ref().take(additional);
    |                                           ^^^^^^ method cannot be called on `&mut parquet::read::deserialize::dictionary::Optional<'_>` due to unsatisfied trait bounds
    |
   ::: src/io/parquet/read/deserialize/dictionary/mod.rs:65:1
    |
65  | pub struct Optional<'a> {
    | ----------------------- doesn't satisfy `_: Iterator`
    |
    = note: the following trait bounds were not satisfied:
            `parquet::read::deserialize::dictionary::Optional<'_>: Iterator`
            which is required by `&mut parquet::read::deserialize::dictionary::Optional<'_>: Iterator`
note: the following trait must be implemented
   --> /home/ritchie46/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/iter/traits/iterator.rs:67:1
    |
67  | pub trait Iterator {
    | ^^^^^^^^^^^^^^^^^^
    = help: items from traits can only be used if the trait is implemented and in scope
    = note: the following trait defines an item `by_ref`, perhaps you need to implement it:
            candidate #1: `Iterator`

error[E0271]: type mismatch resolving `<parquet::read::deserialize::dictionary::nested::PrimitiveDecoder<K> as parquet::read::deserialize::utils::Decoder<'_>>::DecodedState == nested_utils::NestedState`
   --> src/io/parquet/read/deserialize/dictionary/nested.rs:199:13
    |
199 |             extend_from_new_page(page, chunk_size, nested_items, &decoder);
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ type mismatch resolving `<parquet::read::deserialize::dictionary::nested::PrimitiveDecoder<K> as parquet::read::deserialize::utils::Decoder<'_>>::DecodedState == nested_utils::NestedState`
    |
note: expected this to be `(Vec<K>, bitmap::mutable::MutableBitmap)`
   --> src/io/parquet/read/deserialize/dictionary/nested.rs:85:25
    |
85  |     type DecodedState = (Vec<K>, MutableBitmap);
    |                         ^^^^^^^^^^^^^^^^^^^^^^^
    = note: expected tuple `(Vec<K>, bitmap::mutable::MutableBitmap)`
              found struct `nested_utils::NestedState`

@ritchie46 ritchie46 marked this pull request as draft July 20, 2022 09:15
@ritchie46
Copy link
Collaborator Author

closed in favor of #1175

@ritchie46 ritchie46 closed this Jul 22, 2022
@ritchie46 ritchie46 deleted the dict_parquet_nested_update branch July 22, 2022 07:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants