This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Improved performance of reading Binary from parquet #1190
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a flamegraph of a parquet file I saw that
Binary<O>::push
spend a large amount reallocation. This PR pre-allocates a the values buffer in parquet hinted by the capacity. This can prevent a few reallocations. The string/binary size is arbitrarily set to the size of a minimal string, e.g. 3 pointers. Could of course be something else that better fits real world data. I could do some runs to find a distribution?