Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added support to mmap IPC format #1197

Merged
merged 8 commits into from
Aug 4, 2022
Merged

Added support to mmap IPC format #1197

merged 8 commits into from
Aug 4, 2022

Conversation

jorgecarleitao
Copy link
Owner

@jorgecarleitao jorgecarleitao commented Jul 31, 2022

This PR adds support for memory mapping (uncompressed) IPC files into arrays, thereby avoiding data reads.

@jorgecarleitao jorgecarleitao added feature A new feature investigation Issues or PRs that are investigations. Prs may or may not be merged. labels Jul 31, 2022
@codecov
Copy link

codecov bot commented Jul 31, 2022

Codecov Report

Merging #1197 (f263be2) into main (3db00fc) will increase coverage by 0.22%.
The diff coverage is 94.00%.

@@            Coverage Diff             @@
##             main    #1197      +/-   ##
==========================================
+ Coverage   83.28%   83.50%   +0.22%     
==========================================
  Files         366      368       +2     
  Lines       36763    37554     +791     
==========================================
+ Hits        30617    31359     +742     
- Misses       6146     6195      +49     
Impacted Files Coverage Δ
src/ffi/array.rs 83.12% <ø> (+1.22%) ⬆️
src/io/ipc/mod.rs 100.00% <ø> (ø)
src/lib.rs 100.00% <ø> (ø)
src/mmap/mod.rs 84.84% <84.84%> (ø)
src/io/ipc/read/common.rs 94.90% <96.29%> (ø)
src/ffi/mmap.rs 96.74% <96.74%> (ø)
src/io/ipc/read/reader.rs 96.65% <96.77%> (+0.33%) ⬆️
src/array/list/mod.rs 82.65% <100.00%> (ø)
src/ffi/mod.rs 100.00% <100.00%> (ø)
src/io/ipc/read/file_async.rs 61.19% <100.00%> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

src/ffi/mmap.rs Outdated Show resolved Hide resolved
@jorgecarleitao jorgecarleitao changed the title Draft - Added support to mmap IPC format Added support to mmap IPC format Aug 3, 2022
@jorgecarleitao jorgecarleitao marked this pull request as ready for review August 3, 2022 05:17
@jorgecarleitao jorgecarleitao removed the investigation Issues or PRs that are investigations. Prs may or may not be merged. label Aug 4, 2022
@jorgecarleitao jorgecarleitao merged commit 5711cfc into main Aug 4, 2022
@jorgecarleitao jorgecarleitao deleted the mmap branch August 4, 2022 05:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants