This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes.
1. expose more information on the
FileMetaData
.I wanted to know how many
Chunks
there are in the IPC file. This also exposes thesize
attribute as that can also be valuable information.If they are an invariant for unsafe code, I can expose them via functions?
2. use Arc
There was an assumption that
Arc<Mmap
implementsClone + AsRef<[u8]
. It does not. Callingas_ref
on anArc<T>
gives usT
, which was opaque to us.Changed the function signature so that we can pass an
Arc<Mmap>
.