This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Added support for parquet sidecar to FileReader
#1215
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initializing a
FileReader
currently:FileMetadata
to have it available for usersArc<Fn>
on it to filter row groups that most use-cases I saw so far is not usefulThis PR refactors
FileReader::try_new
intoFileReader::new
by allowing its users more flexibility into how the file is read.The main idea is that
FileReader
is now initialized as follows:this gives the user the flexibility to perform the necessary preparation to the metadata (
Schema
androw_groups
) to read the file.let row_groups = metadata.row_groups
if no predictive pushdown is being used.This also allows row groups defined somewhere else (e.g. a parquet sidecar) to be used.