-
Notifications
You must be signed in to change notification settings - Fork 223
Fixed descending ordering when specify nulls first #1286
Conversation
Need a test case to cover |
Codecov ReportBase: 83.04% // Head: 83.12% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1286 +/- ##
==========================================
+ Coverage 83.04% 83.12% +0.08%
==========================================
Files 364 369 +5
Lines 39259 40187 +928
==========================================
+ Hits 32602 33406 +804
- Misses 6657 6781 +124
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I will try to add a test, this may take a time |
BTW, part of the bug will be solved after the row format is introduced into databend's sort. |
add a ut in the latest commit |
#1299 could address the Clippy error. This PR is ready for ready now. |
databend
is a database using arrow2 to sort the data, when running query likeselect * from xx order by xx desc nulls first
, null is the last value not first, seems a logic bug inbuild_comparator_impl