This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Fixed error in memory usage of sliced binary/list/utf8arrays #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 83.12% // Head: 83.11% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1293 +/- ##
==========================================
- Coverage 83.12% 83.11% -0.01%
==========================================
Files 369 369
Lines 40187 40187
==========================================
- Hits 33405 33402 -3
- Misses 6782 6785 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Clippy fails, but it is unrelated to this PR. |
jorgecarleitao
changed the title
|
Thanks @ritchie46 ! |
ritchie46
added a commit
to ritchie46/arrow2
that referenced
this pull request
Mar 29, 2023
ritchie46
added a commit
to ritchie46/arrow2
that referenced
this pull request
Apr 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1292
The
estimated_bytes_sizefunction did not shrink if an Utf8 array was sliced, leading to a slice recursion until there were only 3 elements left in the array. This lead to writing 175e7 / 3 pages to the parquet file, which was insanely slow.This PR adapts
estimated_bytes_sizeso that it reports the sliced array size. It already does this for other data types and I think this is most consistent and least error prone.If you think we should make it a dedicated function or a branch flagged by an extra argument, that's also fine.