This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgecarleitao
force-pushed
the
offsets
branch
from
December 4, 2022 08:08
ab38982
to
0c69455
Compare
jorgecarleitao
force-pushed
the
offsets
branch
from
December 6, 2022 06:25
0c69455
to
832a02f
Compare
Codecov ReportBase: 83.13% // Head: 83.16% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1316 +/- ##
==========================================
+ Coverage 83.13% 83.16% +0.03%
==========================================
Files 369 370 +1
Lines 40245 40192 -53
==========================================
- Hits 33458 33426 -32
+ Misses 6787 6766 -21
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jorgecarleitao
force-pushed
the
offsets
branch
from
December 8, 2022 06:14
8e843ed
to
e226bfd
Compare
jorgecarleitao
force-pushed
the
offsets
branch
from
December 8, 2022 06:40
e226bfd
to
c150c7c
Compare
ritchie46
pushed a commit
to ritchie46/arrow2
that referenced
this pull request
Mar 29, 2023
ritchie46
pushed a commit
to ritchie46/arrow2
that referenced
this pull request
Apr 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a backward incompatible change that improves performance of compute and IO by reducing the number of runtime checks performed to arrays with offsets (Binary, Utf8, List, Map).
It introduces two new structs,
Offsets(Vec<O>)
andOffsetsBuffer(Buffer<O>)
that upheld the invariants of Arrow offsets (i.e. always contain an element and monotonically increasing).This is expected to improve performance of:
take
substring
cast
by skipping checks of whether the offsets are well constructed.
It also removes some uses of unsafe (-42 LOC, +22 LOC)