This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Added Utf8Array::apply_validity
#1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jorgecarleitao Let me know if I can improve anything. |
Arty-Maly
force-pushed
the
apply_validity_utf8
branch
from
43fc2c6
to
9523f71
Compare
Codecov ReportBase: 83.34% // Head: 83.36% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1367 +/- ##
==========================================
+ Coverage 83.34% 83.36% +0.01%
==========================================
Files 371 371
Lines 40317 40321 +4
==========================================
+ Hits 33604 33613 +9
+ Misses 6713 6708 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Arty-Maly
force-pushed
the
apply_validity_utf8
branch
from
9523f71
to
e815e13
Compare
jorgecarleitao
changed the title
Utf8Array::apply_validity
ritchie46
pushed a commit
to ritchie46/arrow2
that referenced
this pull request
Mar 29, 2023
ritchie46
pushed a commit
to ritchie46/arrow2
that referenced
this pull request
Apr 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an
apply_validityfunction to the Utf8Array. Basically I just copied the functionality from PrimitiveArray. If there is a better way of doing this Im open to suggestions.I also was not sure where to put the test for it, so I added it in the same file under a test module.