Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Made some structs and functions public #1375

Merged
merged 3 commits into from
Feb 2, 2023

Conversation

b41sh
Copy link
Contributor

@b41sh b41sh commented Jan 29, 2023

make some structs and functions related to reading and writing nested array public to use them downstream.

InitNested
NestedState

init_nested
create_list
n_columns
create_list
write_rep_and_def
write_def_levels
to_leaves
to_nested
to_parquet_leaves
slice_nested_leaf
slice_parquet_array
get_max_length

@codecov
Copy link

codecov bot commented Jan 29, 2023

Codecov Report

Base: 83.34% // Head: 83.34% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (faf92ac) compared to base (ca14ef0).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1375      +/-   ##
==========================================
- Coverage   83.34%   83.34%   -0.01%     
==========================================
  Files         371      371              
  Lines       40321    40321              
==========================================
- Hits        33607    33605       -2     
- Misses       6714     6716       +2     
Impacted Files Coverage Δ
src/io/parquet/read/mod.rs 100.00% <ø> (ø)
src/io/parquet/write/nested/mod.rs 98.87% <ø> (ø)
src/io/parquet/read/deserialize/mod.rs 74.54% <100.00%> (ø)
src/io/parquet/read/deserialize/nested_utils.rs 85.71% <100.00%> (ø)
src/io/parquet/write/mod.rs 86.38% <100.00%> (ø)
src/io/parquet/write/pages.rs 95.85% <100.00%> (ø)
src/array/binary/mod.rs 90.94% <0.00%> (-1.19%) ⬇️
src/io/ipc/read/file.rs 96.42% <0.00%> (-0.90%) ⬇️
src/io/ipc/read/array/boolean.rs 98.11% <0.00%> (+5.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jorgecarleitao jorgecarleitao changed the title make some structs and functions public Made some structs and functions public Feb 2, 2023
@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Feb 2, 2023
@jorgecarleitao jorgecarleitao merged commit dd32e4c into jorgecarleitao:main Feb 2, 2023
ritchie46 pushed a commit to ritchie46/arrow2 that referenced this pull request Mar 29, 2023
ritchie46 pushed a commit to ritchie46/arrow2 that referenced this pull request Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants