Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added more tests to cast and min/max #253

Merged
merged 2 commits into from
Aug 5, 2021
Merged

Added more tests to cast and min/max #253

merged 2 commits into from
Aug 5, 2021

Conversation

jorgecarleitao
Copy link
Owner

No description provided.

@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Aug 5, 2021
@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #253 (46631a8) into main (d545253) will increase coverage by 0.55%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
+ Coverage   76.76%   77.31%   +0.55%     
==========================================
  Files         232      232              
  Lines       19820    19949     +129     
==========================================
+ Hits        15214    15424     +210     
+ Misses       4606     4525      -81     
Impacted Files Coverage Δ
src/compute/cast/mod.rs 35.14% <80.28%> (+8.04%) ⬆️
src/compute/aggregate/min_max.rs 94.50% <100.00%> (+8.24%) ⬆️
src/array/mod.rs 53.15% <0.00%> (+0.90%) ⬆️
src/array/primitive/mutable.rs 66.81% <0.00%> (+1.32%) ⬆️
src/array/dictionary/mutable.rs 87.50% <0.00%> (+5.00%) ⬆️
src/compute/cast/utf8_to.rs 27.45% <0.00%> (+13.72%) ⬆️
src/compute/cast/primitive_to.rs 55.95% <0.00%> (+47.61%) ⬆️
src/compute/cast/dictionary_to.rs 47.61% <0.00%> (+47.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d545253...46631a8. Read the comment docs.

@jorgecarleitao jorgecarleitao changed the title Added more tests to cast (they were commented out) Added more tests to cast and min/max Aug 5, 2021
@jorgecarleitao jorgecarleitao merged commit e92f47a into main Aug 5, 2021
@jorgecarleitao jorgecarleitao deleted the more_tests branch August 5, 2021 15:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant