Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fixed small inconsistencies between compute::cast and compute::can_cast #295

Merged
merged 1 commit into from
Aug 18, 2021

Conversation

jorgecarleitao
Copy link
Owner

The test of the cast consistency check was incorrect, as it was only checking consistency of d1 with d1 instead of all combinations.

Fixing the test also showed some inconsistencies, which this PR fixes.

@jorgecarleitao jorgecarleitao added the bug Something isn't working label Aug 18, 2021
@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #295 (3cd5089) into main (fa3b003) will increase coverage by 2.14%.
The diff coverage is 99.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #295      +/-   ##
==========================================
+ Coverage   77.51%   79.66%   +2.14%     
==========================================
  Files         315      316       +1     
  Lines       20967    20968       +1     
==========================================
+ Hits        16253    16704     +451     
+ Misses       4714     4264     -450     
Impacted Files Coverage Δ
tests/it/compute/cast.rs 99.31% <99.31%> (ø)
src/compute/cast/mod.rs 89.22% <100.00%> (+42.22%) ⬆️
src/compute/cast/primitive_to.rs 100.00% <0.00%> (+42.04%) ⬆️
src/compute/cast/boolean_to.rs 100.00% <0.00%> (+42.85%) ⬆️
src/compute/cast/utf8_to.rs 92.15% <0.00%> (+64.70%) ⬆️
src/compute/cast/binary_to.rs 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa3b003...3cd5089. Read the comment docs.

@jorgecarleitao jorgecarleitao changed the title Fixed errors in cast. Fixed small inconsistencies between compute::cast and compute::can_cast Aug 18, 2021
@jorgecarleitao jorgecarleitao merged commit 4ffa530 into main Aug 18, 2021
@jorgecarleitao jorgecarleitao deleted the fix-cast branch August 18, 2021 08:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant