Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added API to FFI Field #321

Merged
merged 5 commits into from
Aug 24, 2021
Merged

Added API to FFI Field #321

merged 5 commits into from
Aug 24, 2021

Conversation

jorgecarleitao
Copy link
Owner

@jorgecarleitao jorgecarleitao commented Aug 23, 2021

So that the fields can be imported and exported from the C data interface.

The public API is different since ownership rules changed (#328); see examples/ffi.rs with a complete example.

Closes #328.

@jorgecarleitao jorgecarleitao added the feature A new feature label Aug 23, 2021
@codecov
Copy link

codecov bot commented Aug 23, 2021

Codecov Report

Merging #321 (1fc3e04) into main (3ce4f1c) will increase coverage by 0.08%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
+ Coverage   80.53%   80.61%   +0.08%     
==========================================
  Files         324      325       +1     
  Lines       21208    21220      +12     
==========================================
+ Hits        17080    17107      +27     
+ Misses       4128     4113      -15     
Impacted Files Coverage Δ
arrow-pyarrow-integration-testing/src/lib.rs 0.00% <ø> (ø)
src/array/boolean/ffi.rs 0.00% <0.00%> (ø)
src/array/struct_.rs 42.85% <0.00%> (ø)
src/array/union/ffi.rs 0.00% <0.00%> (ø)
src/ffi/schema.rs 58.18% <44.77%> (+2.88%) ⬆️
src/array/binary/ffi.rs 81.81% <100.00%> (ø)
src/array/list/ffi.rs 80.00% <100.00%> (ø)
src/array/primitive/ffi.rs 75.00% <100.00%> (ø)
src/ffi/array.rs 41.66% <100.00%> (-1.58%) ⬇️
src/ffi/ffi.rs 92.08% <100.00%> (+5.63%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ce4f1c...1fc3e04. Read the comment docs.

@jorgecarleitao
Copy link
Owner Author

fwi @ritchie46 , since this adds some backward incompatible changes to FFI.

OTOH, we can now share Field in the FFI

@ritchie46
Copy link
Collaborator

Right, will take a look!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align FFI API with arrow's C++ API
2 participants