Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fixed error in dict equality #333

Merged
merged 1 commit into from
Aug 24, 2021
Merged

Fixed error in dict equality #333

merged 1 commit into from
Aug 24, 2021

Conversation

jorgecarleitao
Copy link
Owner

@jorgecarleitao jorgecarleitao commented Aug 24, 2021

This also changes the dictionary iterator over values to be of Box<dyn Scalar>, since it is expected to return a single entry. This is consistent with what its slot contains.

Closes #335

@jorgecarleitao jorgecarleitao added the bug Something isn't working label Aug 24, 2021
@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #333 (effecde) into main (a9932a6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #333   +/-   ##
=======================================
  Coverage   80.95%   80.95%           
=======================================
  Files         325      325           
  Lines       21069    21065    -4     
=======================================
- Hits        17057    17054    -3     
+ Misses       4012     4011    -1     
Impacted Files Coverage Δ
src/array/dictionary/iterator.rs 50.00% <ø> (ø)
src/array/dictionary/mod.rs 72.50% <100.00%> (ø)
src/array/equal/dictionary.rs 100.00% <100.00%> (ø)
tests/it/array/equal/dictionary.rs 100.00% <100.00%> (ø)
src/io/json/read/reader.rs 74.32% <0.00%> (-1.36%) ⬇️
src/scalar/equal.rs 54.54% <0.00%> (+2.27%) ⬆️
src/io/json_integration/write.rs 6.25% <0.00%> (+6.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9932a6...effecde. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change dictionary iterator of values from Arrays of one element to Scalars
1 participant