Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Bumped tonic and prost in flight #344

Merged
merged 2 commits into from
Aug 26, 2021
Merged

Bumped tonic and prost in flight #344

merged 2 commits into from
Aug 26, 2021

Conversation

PsiACE
Copy link
Contributor

@PsiACE PsiACE commented Aug 26, 2021

  • bump deps
  • sync protocol

Signed-off-by: Chojan Shang psiace@outlook.com

Signed-off-by: Chojan Shang <psiace@outlook.com>
@PsiACE
Copy link
Contributor Author

PsiACE commented Aug 26, 2021

Conversion from prost_types::Timestamp to SystemTime can cause an overflow and panic

Details
Package prost-types
Version 0.7.0
URL tokio-rs/prost#438
Date 2021-07-08
Patched versions >=0.8.0

Affected versions of this crate contained a bug in which untrusted input could cause an overflow and panic when converting a Timestamp to SystemTime.

It is recommended to upgrade to prost-types v0.8 and switch the usage of From<Timestamp> for SystemTime to TryFrom<Timestamp> for SystemTime.

See #438 for more information.

See advisory page for additional details.

@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #344 (727c3b2) into main (81ec49c) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #344      +/-   ##
==========================================
- Coverage   81.00%   80.95%   -0.05%     
==========================================
  Files         326      326              
  Lines       21154    21186      +32     
==========================================
+ Hits        17136    17152      +16     
- Misses       4018     4034      +16     
Impacted Files Coverage Δ
arrow-flight/src/arrow.flight.protocol.rs 0.00% <0.00%> (ø)
src/io/json_integration/write.rs 0.00% <0.00%> (-6.25%) ⬇️
src/io/json_integration/schema.rs 43.71% <0.00%> (-0.32%) ⬇️
src/bitmap/utils/mod.rs 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81ec49c...727c3b2. Read the comment docs.

Signed-off-by: Chojan Shang <psiace@outlook.com>
@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Aug 26, 2021
@jorgecarleitao jorgecarleitao changed the title Bumped tonic & prost Bumped tonic and prost in flight Aug 26, 2021
@jorgecarleitao
Copy link
Owner

Thanks a lot, @PsiACE ! integration tests pass ✅, ready to merge 👍

@jorgecarleitao jorgecarleitao merged commit c99a95d into jorgecarleitao:main Aug 26, 2021
@PsiACE PsiACE deleted the bump-tonic branch August 27, 2021 00:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants