Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fixed display of timestamp with tz. #375

Merged
merged 1 commit into from
Sep 4, 2021
Merged

Fixed display of timestamp with tz. #375

merged 1 commit into from
Sep 4, 2021

Conversation

jorgecarleitao
Copy link
Owner

When a timestamp has a timezone, it is stored as UTC and the timezone denotes the representation. Thus, 0i64, representing 1970-01-01 00:00:00.0 with an offset of +02:00 should be represented as 1970-01-01 02:00:00.0 +02:00.

@jorgecarleitao jorgecarleitao added the bug Something isn't working label Sep 3, 2021
@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #375 (56d34ec) into main (dbb7b8a) will increase coverage by 0.00%.
The diff coverage is 62.50%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #375   +/-   ##
=======================================
  Coverage   81.08%   81.09%           
=======================================
  Files         328      328           
  Lines       21748    21772   +24     
=======================================
+ Hits        17635    17655   +20     
- Misses       4113     4117    +4     
Impacted Files Coverage Δ
tests/it/io/print.rs 100.00% <ø> (ø)
src/array/display.rs 61.70% <50.00%> (+2.57%) ⬆️
src/temporal_conversions.rs 75.38% <60.00%> (-4.62%) ⬇️
tests/it/array/primitive/mod.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbb7b8a...56d34ec. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 2ebe664 into main Sep 4, 2021
@jorgecarleitao jorgecarleitao deleted the tz_display branch September 4, 2021 11:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant