This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Improved performance of writing to CSV (20-25%) #382
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we write to CSV by using an
Iterator<Item=Vec<u8>>
. This requires a new allocation per non-null item.This PR uses
StreamingIterator
to significantly reduce the number of allocations.A
StreamingIterator
is an Iterator-like trait that allows yielding references of itself,&[u8]
in this case. We maintain an internal buffer ofVec<u8>
on the (streaming) iterator and re-use it across items within the array.In summary, this replaces (1 alloc + write bytes) by a (maybe 1 realloc + write bytes) per non-null item. For types that require a fixed number of bytes (e.g. all our primitive types), it results in a single allocation per array, as opposed to an allocation per non-null item.