Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fixed error in MutableBitmap::push_unchecked #384

Merged
merged 1 commit into from
Sep 6, 2021
Merged

Conversation

jorgecarleitao
Copy link
Owner

The push assumed that all bits were already unset, which is no longer the case.

@codecov
Copy link

codecov bot commented Sep 6, 2021

Codecov Report

Merging #384 (6d55d31) into main (877739b) will increase coverage by 0.00%.
The diff coverage is 71.42%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #384   +/-   ##
=======================================
  Coverage   81.12%   81.13%           
=======================================
  Files         331      331           
  Lines       21957    21956    -1     
=======================================
  Hits        17813    17813           
+ Misses       4144     4143    -1     
Impacted Files Coverage Δ
src/array/primitive/mutable.rs 87.30% <60.00%> (+0.52%) ⬆️
src/bitmap/mutable.rs 89.16% <100.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 877739b...6d55d31. Read the comment docs.

@jorgecarleitao jorgecarleitao added the bug Something isn't working label Sep 6, 2021
@jorgecarleitao jorgecarleitao changed the title Fixed error in pushing bit Fixed error in MutableBitmap::push_unchecked Sep 6, 2021
@jorgecarleitao jorgecarleitao merged commit bd7ad8d into main Sep 6, 2021
@jorgecarleitao jorgecarleitao deleted the fix_bit_push branch September 6, 2021 15:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant