Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added property testing #460

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Added property testing #460

merged 1 commit into from
Sep 29, 2021

Conversation

jorgecarleitao
Copy link
Owner

This PR adds a couple of tests using proptest, a testing framework to test code invariants. See here or here for an introduction to the subject.

This framework is being used by the portable SIMD group, and in my opinion it makes a lot of sense here also, since we can rigorously declare and test the properties of our operations.

@jorgecarleitao jorgecarleitao added the testing PRs that only increase coverage label Sep 28, 2021
@jorgecarleitao
Copy link
Owner Author

Failing MIRI is related to proptest using clib::getcwd, which is not supported in isolation mode. Question posed upstream.

@jorgecarleitao jorgecarleitao force-pushed the proptest branch 2 times, most recently from d2b85e9 to 73e45a3 Compare September 28, 2021 18:18
@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #460 (83d67ba) into main (90887c2) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #460      +/-   ##
==========================================
- Coverage   80.01%   80.00%   -0.02%     
==========================================
  Files         371      371              
  Lines       22833    22925      +92     
==========================================
+ Hits        18269    18340      +71     
- Misses       4564     4585      +21     
Impacted Files Coverage Δ
tests/it/array/binary/mutable.rs 100.00% <ø> (ø)
tests/it/array/utf8/mutable.rs 100.00% <ø> (ø)
tests/it/bitmap/bitmap_ops.rs 100.00% <100.00%> (ø)
tests/it/bitmap/mod.rs 100.00% <100.00%> (ø)
tests/it/bitmap/utils/mod.rs 100.00% <100.00%> (ø)
tests/it/bitmap/utils/slice_iterator.rs 100.00% <100.00%> (+1.09%) ⬆️
src/io/avro/read/schema.rs 42.52% <0.00%> (-1.15%) ⬇️
src/ffi/mod.rs 100.00% <0.00%> (ø)
tests/it/io/csv/write.rs 96.15% <0.00%> (+0.40%) ⬆️
src/compute/arithmetics/time.rs 46.93% <0.00%> (+2.04%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90887c2...83d67ba. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
testing PRs that only increase coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant