Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added support for DataType::Map and MapArray #464

Merged
merged 3 commits into from
Oct 2, 2021
Merged

Added support for DataType::Map and MapArray #464

merged 3 commits into from
Oct 2, 2021

Conversation

jorgecarleitao
Copy link
Owner

@jorgecarleitao jorgecarleitao commented Sep 29, 2021

  • physical and logical type
  • FFI consume and produce
  • IPC consume and produce
  • integration tests unskipped

@jorgecarleitao jorgecarleitao added the feature A new feature label Sep 29, 2021
@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #464 (8bf843a) into main (2d84c2d) will decrease coverage by 0.23%.
The diff coverage is 50.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #464      +/-   ##
==========================================
- Coverage   80.19%   79.95%   -0.24%     
==========================================
  Files         374      379       +5     
  Lines       23025    23215     +190     
==========================================
+ Hits        18465    18562      +97     
- Misses       4560     4653      +93     
Impacted Files Coverage Δ
src/array/display.rs 61.15% <ø> (ø)
src/array/ffi.rs 65.00% <0.00%> (-3.43%) ⬇️
src/array/growable/mod.rs 50.00% <ø> (ø)
src/array/list/mod.rs 75.29% <0.00%> (+2.56%) ⬆️
src/array/map/ffi.rs 0.00% <0.00%> (ø)
src/array/mod.rs 53.27% <0.00%> (-1.35%) ⬇️
src/compute/aggregate/memory.rs 23.07% <0.00%> (-1.93%) ⬇️
src/datatypes/field.rs 29.13% <0.00%> (-0.24%) ⬇️
src/ffi/array.rs 64.70% <0.00%> (-4.05%) ⬇️
src/io/parquet/read/primitive/dictionary.rs 78.43% <ø> (-0.42%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d84c2d...8bf843a. Read the comment docs.

@jorgecarleitao jorgecarleitao changed the title Added support for Map and MapArray Added support for DataType::Map and MapArray Sep 29, 2021
Copy link
Contributor

@nevi-me nevi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments on some error messages

src/array/list/mod.rs Show resolved Hide resolved
src/array/map/mod.rs Outdated Show resolved Hide resolved
src/array/map/mod.rs Outdated Show resolved Hide resolved
src/io/json_integration/schema.rs Outdated Show resolved Hide resolved
src/scalar/mod.rs Show resolved Hide resolved
src/array/mod.rs Outdated Show resolved Hide resolved
src/array/mod.rs Outdated Show resolved Hide resolved
src/array/mod.rs Outdated Show resolved Hide resolved
src/compute/aggregate/memory.rs Outdated Show resolved Hide resolved
@jorgecarleitao
Copy link
Owner Author

Thank you very much, @nevi-me for your review (great to see you :D)

@jorgecarleitao jorgecarleitao mentioned this pull request Oct 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants