Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

DRY of type check and len check code in compute #474

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

yjhmelody
Copy link
Contributor

No description provided.

Copy link
Owner

@jorgecarleitao jorgecarleitao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! Looks great. I left two suggestions so that we do not introduce any new public API.

src/compute/arithmetics/basic/common.rs Show resolved Hide resolved
src/compute/arithmetics/basic/common.rs Show resolved Hide resolved
@jorgecarleitao jorgecarleitao changed the title chore: reducing type check and len check code DRY of type check and len check code in compute Sep 30, 2021
@jorgecarleitao jorgecarleitao added the testing PRs that only increase coverage label Sep 30, 2021
@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #474 (f4624da) into main (b78eeb7) will increase coverage by 0.17%.
The diff coverage is 88.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #474      +/-   ##
==========================================
+ Coverage   80.02%   80.20%   +0.17%     
==========================================
  Files         371      372       +1     
  Lines       22848    22808      -40     
==========================================
+ Hits        18285    18293       +8     
+ Misses       4563     4515      -48     
Impacted Files Coverage Δ
src/compute/nullif.rs 0.00% <0.00%> (ø)
src/compute/arithmetics/basic/div.rs 90.74% <66.66%> (+9.07%) ⬆️
src/compute/arithmetics/basic/common.rs 80.00% <80.00%> (ø)
src/compute/arithmetics/basic/add.rs 100.00% <100.00%> (+14.81%) ⬆️
src/compute/arithmetics/basic/mul.rs 100.00% <100.00%> (+14.81%) ⬆️
src/compute/arithmetics/basic/rem.rs 100.00% <100.00%> (+7.69%) ⬆️
src/compute/arithmetics/basic/sub.rs 100.00% <100.00%> (+14.81%) ⬆️
src/compute/arithmetics/decimal/add.rs 83.09% <100.00%> (+2.27%) ⬆️
src/compute/arithmetics/decimal/div.rs 81.01% <100.00%> (+2.00%) ⬆️
src/compute/arithmetics/decimal/mul.rs 81.01% <100.00%> (+2.00%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b78eeb7...f4624da. Read the comment docs.

@yjhmelody
Copy link
Contributor Author

@jorgecarleitao i have add pub(crate)use common: : * already

@jorgecarleitao jorgecarleitao merged commit 6f4231d into jorgecarleitao:main Sep 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
testing PRs that only increase coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants