This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Improved inference and deserialization of CSV #483
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
&[u8] -> utf8
for types that do not need such conversion (integer, boolean, float)lazy_static
andregex
, so that the inference is 100% consistent with deserializationThe deserialization and inference of timestamps with timezone assumes RFC3339. Users may extend the inferer and deserializer to handle other formats.
This also fixes a bug on which datetimes were being parsed as
Date64
, whendate64
is expected to be a multiple of 86400000 and not an arbitrary number. They are now inferer and parsed as aTimestamp(Millisecond, None)