Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Implement BitXor trait for Bitmap #485

Merged
merged 1 commit into from
Oct 2, 2021

Conversation

houqp
Copy link
Collaborator

@houqp houqp commented Oct 2, 2021

For #457. To calculate cast error bitmap, we need to run array_validity ^ cast_validity.

@houqp houqp requested a review from jorgecarleitao October 2, 2021 07:04
@codecov
Copy link

codecov bot commented Oct 2, 2021

Codecov Report

Merging #485 (be9abfc) into main (a15044a) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #485      +/-   ##
==========================================
- Coverage   80.33%   80.32%   -0.02%     
==========================================
  Files         374      374              
  Lines       22919    22923       +4     
==========================================
  Hits        18413    18413              
- Misses       4506     4510       +4     
Impacted Files Coverage Δ
src/bitmap/bitmap_ops.rs 93.81% <0.00%> (-4.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a15044a...be9abfc. Read the comment docs.

@jorgecarleitao jorgecarleitao changed the title Implement BitXor trait for Bitmap Implement BitXor trait for Bitmap Oct 2, 2021
@jorgecarleitao jorgecarleitao added the feature A new feature label Oct 2, 2021
@jorgecarleitao jorgecarleitao merged commit 2173ac0 into jorgecarleitao:main Oct 2, 2021
@houqp houqp deleted the qp_xor branch October 2, 2021 07:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants