Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Speedup/simplify bitwise operations (avoid extra allocation) #586

Merged
merged 5 commits into from
Nov 8, 2021

Conversation

Dandandan
Copy link
Collaborator

Avoids an extra allocation for binary bitwise ops.

@Dandandan Dandandan changed the title Speedup bitwise Speedup binary bitwise operation Nov 7, 2021
@Dandandan Dandandan changed the title Speedup binary bitwise operation Speedup binary bitwise operations Nov 7, 2021
@codecov
Copy link

codecov bot commented Nov 7, 2021

Codecov Report

Merging #586 (e68cda8) into main (e9d618c) will increase coverage by 0.04%.
The diff coverage is 93.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #586      +/-   ##
==========================================
+ Coverage   78.99%   79.04%   +0.04%     
==========================================
  Files         399      399              
  Lines       24752    24743       -9     
==========================================
+ Hits        19554    19558       +4     
+ Misses       5198     5185      -13     
Impacted Files Coverage Δ
benches/bitwise.rs 0.00% <ø> (ø)
src/bitmap/bitmap_ops.rs 86.45% <93.10%> (-2.76%) ⬇️
src/array/growable/mod.rs 21.56% <0.00%> (-4.63%) ⬇️
src/compute/arithmetics/time.rs 44.89% <0.00%> (-2.05%) ⬇️
src/bitmap/utils/slice_iterator.rs 91.04% <0.00%> (-1.50%) ⬇️
src/compute/cast/dictionary_to.rs 24.39% <0.00%> (-0.61%) ⬇️
src/io/parquet/read/mod.rs 32.62% <0.00%> (-0.37%) ⬇️
src/ffi/schema.rs 69.03% <0.00%> (-0.20%) ⬇️
src/array/mod.rs 59.64% <0.00%> (ø)
src/types/mod.rs 23.61% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9d618c...e68cda8. Read the comment docs.

@Dandandan Dandandan changed the title Speedup binary bitwise operations Speedup bitwise operations (avoid extra allocation) Nov 7, 2021
@jorgecarleitao
Copy link
Owner

please ignore the security audit: I created the advisory for flatbuffers but have not finished auditing this and arrow-format crate to double check that we are not using any of the unsound but safe APIs incorrectly.

@Dandandan Dandandan changed the title Speedup bitwise operations (avoid extra allocation) Speedup/simplify bitwise operations (avoid extra allocation) Nov 7, 2021
@jorgecarleitao jorgecarleitao merged commit 6e9ea35 into jorgecarleitao:main Nov 8, 2021
@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Nov 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants