Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fixed compilation with individual features activated #642

Merged
merged 3 commits into from
Nov 27, 2021

Conversation

ritchie46
Copy link
Collaborator

Could not release polars without activating the whole compute feature. Lexical is needed for casting, this exposes the module when cast is activated.

@ritchie46
Copy link
Collaborator Author

More coming up:

$ cargo hack check --each-feature --no-dev-deps reveals more.

@codecov
Copy link

codecov bot commented Nov 27, 2021

Codecov Report

Merging #642 (0ed8464) into main (b853d95) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #642      +/-   ##
==========================================
- Coverage   69.91%   69.90%   -0.01%     
==========================================
  Files         299      299              
  Lines       16628    16628              
==========================================
- Hits        11625    11624       -1     
- Misses       5003     5004       +1     
Impacted Files Coverage Δ
src/io/avro/read/decompress.rs 80.64% <ø> (ø)
src/bitmap/utils/slice_iterator.rs 91.04% <0.00%> (-1.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b853d95...0ed8464. Read the comment docs.

@ritchie46 ritchie46 changed the title expose lexical when cast is activated Fix compilation with individual features activated Nov 27, 2021
@ritchie46
Copy link
Collaborator Author

ritchie46 commented Nov 27, 2021

I also restored the ArrowError::Other variant. Maybe you want something else for that? It was still needed when compiling with avro read io.

What do you think of adding $ cargo hack check --each-feature --no-dev-deps --exclude-features=full,compute,simd to CI? Dealing with different feature sets becomes hard to maintain if we don't check this automatically.

It has saved me a lot when pushing seemingly unrelated changes.

@jorgecarleitao
Copy link
Owner

Thanks! dam, yeap, I was trying to get something like that; the cargo hack one is a great suggestion!

I think we should turn the error into ArrowError::InvalidArgumentError so that we do not need the Other variant. could you do that instead (or let me know and I will do it)?

I will do a hot fix on this right after this PR is merged, and handle the CI afterwards. Sorry for the bogged release.

@ritchie46
Copy link
Collaborator Author

No worries! I changed the error type. It should be good to go.

@jorgecarleitao jorgecarleitao merged commit 20657a2 into jorgecarleitao:main Nov 27, 2021
@jorgecarleitao jorgecarleitao added the bug Something isn't working label Nov 27, 2021
@jorgecarleitao jorgecarleitao changed the title Fix compilation with individual features activated Fixed compilation with individual features activated Nov 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants