Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Simplified Primitive and Boolean scalar #648

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Conversation

jorgecarleitao
Copy link
Owner

Made .value() return Option<T> instead of T and simplified their internals.

@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #648 (e1dbf6f) into main (f2c7503) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #648      +/-   ##
==========================================
+ Coverage   69.90%   69.97%   +0.07%     
==========================================
  Files         299      299              
  Lines       16628    16732     +104     
==========================================
+ Hits        11624    11709      +85     
- Misses       5004     5023      +19     
Impacted Files Coverage Δ
src/compute/comparison/mod.rs 23.07% <ø> (ø)
src/scalar/boolean.rs 81.81% <100.00%> (-4.85%) ⬇️
src/scalar/primitive.rs 72.22% <100.00%> (-9.26%) ⬇️
src/array/utf8/mutable.rs 85.77% <0.00%> (+0.39%) ⬆️
src/array/binary/mutable.rs 80.16% <0.00%> (+0.80%) ⬆️
src/io/parquet/read/nested_utils.rs 78.43% <0.00%> (+0.98%) ⬆️
src/compute/cast/primitive_to.rs 77.41% <0.00%> (+1.49%) ⬆️
src/compute/arithmetics/time.rs 44.23% <0.00%> (+1.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2c7503...e1dbf6f. Read the comment docs.

@jorgecarleitao jorgecarleitao force-pushed the simpler_scalar branch 3 times, most recently from 4a8c96b to 70c7d9e Compare November 30, 2021 18:51
@jorgecarleitao jorgecarleitao changed the title Simplified Primitive and Boolean scalar. Simplified Primitive and Boolean scalar Nov 30, 2021
Copy link
Contributor

@yjhmelody yjhmelody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jorgecarleitao jorgecarleitao merged commit 8300684 into main Dec 1, 2021
@jorgecarleitao jorgecarleitao deleted the simpler_scalar branch December 1, 2021 16:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants