Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Avoid double utf8 checks on MutableUtf8 -> Utf8 #655

Merged
merged 2 commits into from
Dec 2, 2021
Merged

Conversation

jorgecarleitao
Copy link
Owner

No description provided.

@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Dec 2, 2021
@jorgecarleitao jorgecarleitao changed the title Avoid utf8 checks on MutableUtf8 -> Utf8 Avoid double utf8 checks on MutableUtf8 -> Utf8 Dec 2, 2021
@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #655 (6e7c5cf) into main (23c7d8a) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #655      +/-   ##
==========================================
- Coverage   69.92%   69.91%   -0.02%     
==========================================
  Files         299      299              
  Lines       16647    16684      +37     
==========================================
+ Hits        11640    11664      +24     
- Misses       5007     5020      +13     
Impacted Files Coverage Δ
src/array/utf8/mutable.rs 85.49% <50.00%> (-0.29%) ⬇️
src/compute/arithmetics/time.rs 42.30% <0.00%> (-1.93%) ⬇️
src/scalar/boolean.rs 85.71% <0.00%> (-0.96%) ⬇️
src/compute/comparison/mod.rs 23.07% <0.00%> (ø)
src/bitmap/immutable.rs 86.58% <0.00%> (+0.09%) ⬆️
src/io/parquet/read/nested_utils.rs 78.43% <0.00%> (+0.98%) ⬆️
src/scalar/primitive.rs 85.71% <0.00%> (+4.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23c7d8a...6e7c5cf. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 4320687 into main Dec 2, 2021
@jorgecarleitao jorgecarleitao deleted the mutable_utf8 branch December 2, 2021 21:13
@ritchie46
Copy link
Collaborator

Was it called often? 😁

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants